fix: Fix rows counter in the Edit Grade modal window #389
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #389 +/- ##
===========================================================
Coverage 94.98% 94.98%
===========================================================
Files 140 140
Lines 1356 1357 +1
Branches 264 264
===========================================================
+ Hits 1288 1289 +1
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
mphilbrick211
added
the
backport
|
Hi @farhaanbukhsh! The master for this PR has been merged, so this one should be good-to-go. Thanks! |
|
@mphilbrick211 sure will merge this after testing :) |
There was a problem hiding this comment.
Hey @Lunyachek can you have look at the comment and test it. Thanks a lot for the PR. Let me know if you need more clarification.
| const tableData = [ | ||
| ...data, | ||
| { | ||
| adjustedGrade: <AdjustedGradeInput />, | ||
| date: formatDateForDisplay(new Date()), | ||
| reason: <ReasonInput />, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
should we put a check on the data something like
| const tableData = [ | |
| ...data, | |
| { | |
| adjustedGrade: <AdjustedGradeInput />, | |
| date: formatDateForDisplay(new Date()), | |
| reason: <ReasonInput />, | |
| }, | |
| ]; | |
| const tableData = data ? [ | |
| ...data, | |
| { | |
| adjustedGrade: <AdjustedGradeInput />, | |
| date: formatDateForDisplay(new Date()), | |
| reason: <ReasonInput />, | |
| }, | |
| ] : []; |
While testing I landed up on error when data was undefined and this happened multiple times mostly I guess when the states were getting updated.
There was a problem hiding this comment.
We should backport 4e9270a
hey @mphilbrick211 I have reviewed the PR and added few suggestion and changes |
Thanks, @farhaanbukhsh! Flagging this for you, @Lunyachek! |
|
@Lunyachek can you please backport the additional commit so that we can safely merge the PR? |
This is backport from master - #310
TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting
What changed?
FYI: @openedx/content-aurora